fix: adjust block swapping logic for forward-only mode in ModelOffloader #675
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow this important i had some block swap implementation based on musubi tuner maybe i have same error as well :D |
|
@kohya-ss i tried to implement this into my app but got errors after several times testing maybe i am doing wrong but here some findings 
|
Thanks for reporting it, indeed the current code doesn't work when "block_to_swap >= num_blocks // 2". I'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When block swap is enabled only for the forward pass, extra blocks are mistakenly swapped. This caused an error after sample image generation (which is the forward pass only).
This also significantly improves inference speed when using block swap.
Additional tests are needed for the inference scripts for each architecture.
closes #654